Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add scenario check custom nonce toggle works correctly. #23418

Merged
merged 5 commits into from
Mar 19, 2024
Merged

test: add scenario check custom nonce toggle works correctly. #23418

merged 5 commits into from
Mar 19, 2024

Conversation

sleepytanya
Copy link
Contributor

@sleepytanya sleepytanya commented Mar 11, 2024 •
edited
Loading

Description

In this PR we add the scenario for the flow 'Check custom nonce toggle'.
This task belongs to the effort of documenting manual QA flows in this Epic.

Open in GitHub Codespaces

Related issues

Fixes: 21989

Manual testing steps

  1. Verify that the test steps align with the sequence in the video.
    You can find rendered table here.

Screenshots/Recordings

789.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sleepytanya sleepytanya requested a review from a team as a code owner March 11, 2024 22:50
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sleepytanya sleepytanya self-assigned this Mar 11, 2024
@sleepytanya sleepytanya added release-11.13.0 Issue or pull request that will be included in release 11.13.0 team-confirmations-system DEPRECATED: please use "team-confirmations" label instead labels Mar 11, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.45%. Comparing base (59e9948) to head (9ecbe18).

❗ Current head 9ecbe18 differs from pull request most recent head 9dba3b3. Consider uploading reports for the commit 9dba3b3 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #23418      +/-   ##
===========================================
- Coverage    68.45%   68.45%   -0.01%     
===========================================
  Files         1142     1141       -1     
  Lines        43773    43769       -4     
  Branches     11719    11729      +10     
===========================================
- Hits         29964    29958       -6     
- Misses       13809    13811       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sleepytanya sleepytanya requested a review from segun March 16, 2024 05:02
hjetpoluru
hjetpoluru approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [9ecbe18]
Page Load Metrics (1100 ± 495 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint802361264421
domContentLoaded1086352412
load64260411001032495
domInteractive1086352412
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@sleepytanya sleepytanya merged commit 02f634d into develop Mar 19, 2024
61 of 64 checks passed
@sleepytanya sleepytanya deleted the check-nonce-toggle branch March 19, 2024 14:23
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
@metamaskbot metamaskbot added release-11.14.0 Issue or pull request that will be included in release 11.14.0 and removed release-11.14.0 Issue or pull request that will be included in release 11.14.0 labels Mar 19, 2024
@metamaskbot
Copy link
Collaborator

More than one release label on PR. Keeping the lowest one (release-11.13.0) on PR and removing other release labels (release-11.14.0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hjetpoluru hjetpoluru hjetpoluru approved these changes

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@seaona seaona Awaiting requested review from seaona

@benjisclowder benjisclowder Awaiting requested review from benjisclowder

@chloeYue chloeYue Awaiting requested review from chloeYue

@segun segun Awaiting requested review from segun

Assignees

@sleepytanya sleepytanya

Labels
release-11.13.0 Issue or pull request that will be included in release 11.13.0 team-confirmations-system DEPRECATED: please use "team-confirmations" label instead
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Advanced settings: Check “Customize transaction nonce” toggle works correctly
4 participants
@sleepytanya @metamaskbot @OGPoyraz @hjetpoluru